Re: cvs: php4 /ext/oci8 oci8.c

I actually thought of doing so, but then looked into other file protected by Safe Mode in ext/standard/file.c and noticed that there was no warning issued for safe mode, so I decided to follow consistency. I will add the warning, that is definitely the way to go. Check yourself too, maybe the other should have warnings too. Or have I just overlooked it completely? -- Maxim Maletsky maxim@php.net Derick Rethans <derick@php.net> wrote... : > On Thu, 21 Nov 2002, Maxim Maletsky wrote: > > > maxim Thu Nov 21 15:28:11 2002 EDT > > > > Modified files: > > /php4/ext/oci8 oci8.c > > Log: > > Disabled OCIPasswordChange() in safe mode. Possible security risks. > > > > > > + /* Disalllow in Safe Mode */ > > + if (PG(safe_mode)) { > > + RETURN_FALSE; > > + } > > You should add a warning there and not fail without a reason. > > Derick > > -- > > --------------------------------------------------------------------------- > Derick Rethans � > l��V)|��,Q�"�http://derickrethans.nl/ > JDI Media Solutions > --------------[ if you hold a unix shell to your ear, do you hear the c? ]- > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >