Re: cvs: php4 /sapi/milter Makefile.frag TODO config.m4 getopt.c php_milter.c
| From: | Jani Taskinen | Date: | Sun, 01 Dec 2002 05:17:46 +0000 |
| Subject: | Re: cvs: php4 /sapi/milter Makefile.frag TODO config.m4 getopt.c php_milter.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-16792@lists.php.net to get a copy of this message | ||
1. Whatta hell is this useful for?
2. You have never read the CODING_STANDARDS or README.CVS-RULES ?
- This is C code..so no // comments!!
- THOU SHALT NOT COMMIT WITHOUT TESTING!!!
(the config.m4 affects EVERYTHING even if the extension itself is not enabled!)
I fixed the broken build..you should fix the coding style and remove
also those // comments.
--Jani
On Sun, 1 Dec 2002, Harald Radi wrote:
>phanto Sat Nov 30 22:37:50 2002 EDT
>
> Added files:
> /php4/sapi/milter getopt.c
>
> Modified files:
> /php4/sapi/milter config.m4 Makefile.frag php_milter.c TODO
> Log:
> it finally compiles now
> tests will follow tomorrow
>
>
--
<- For Sale! ->