Re: cvs: php4 /main fopen_wrappers.c

See my postings on php-dev about this. This particular patch is just one part of the problem. Shane Jani Taskinen wrote:

      MFH?? And are there possibly some bug reports caused by this..?
          --Jani
     

On Sun, 1 Dec 2002, Shane Caraveo wrote:

shane Sun Dec 1 16:28:28 2002 EDT

Modified files:                /php4/main	fopen_wrappers.c Log:

php_error_docref aborts cgi. This broke using php as cgi under apache/mod_cgi with the cgi-script directive and bang lines in php scripts. removing it allows this to work again. Index: php4/main/fopen_wrappers.c diff -u php4/main/fopen_wrappers.c:1.153 php4/main/fopen_wrappers.c:1.154 --- php4/main/fopen_wrappers.c:1.153 Fri Nov 8 17:48:01 2002 +++ php4/main/fopen_wrappers.c Sun Dec 1 16:28:27 2002 @@ -16,7 +16,7 @@

  |          Jim Winstead <jimw@php.net>                                 |

+----------------------------------------------------------------------+ */ -/* $Id: fopen_wrappers.c,v 1.153 2002/11/08 22:48:01 iliaa Exp $ */ +/* $Id: fopen_wrappers.c,v 1.154 2002/12/01 21:28:27 shane Exp $ */ /* {{{ includes */ @@ -348,8 +348,8 @@ fp = NULL; } if (!fp) { - php_error_docref(NULL TSRMLS_CC, E_ERROR, "Unable to open %s", filename); STR_FREE(SG(request_info).path_translated); /* for same reason as above */ + SG(request_info).path_translated = NULL; return FAILURE; }