Re: cvs: php4 / TODO /ext/bz2 bz2.c /ext/sockets sockets.c

At 23:15 01.12.2002, Sterling Hughes wrote:

sterling                Sun Dec  1 17:15:41 2002 EDT

Modified files:

    /php4       TODO
    /php4/ext/bz2       bz2.c
    /php4/ext/sockets   sockets.c

Log: TODO: Cleanup elements that have happened, or most likely won't happen. There is probably more that should be gone, but its still a move in the right direction. Other stuff is ws/formatting changes Index: php4/TODO diff -u php4/TODO:1.136 php4/TODO:1.137

--- php4/TODO:1.136     Wed Nov 13 04:11:19 2002

+++ php4/TODO Sun Dec 1 17:15:37 2002 @@ -3,9 +3,7 @@ Zend (...)

-    * Change PHP error messages, so that they point to pages or sections
-      in the PHP Manual.

That is not only for all messages yet. See sockets.c in your commit down below.

-    * Activate all extensions by default that don't rely on external
-      dependencies. (eg ftp) (DONE?)

So have we decided on that now?

(...) Index: php4/ext/bz2/bz2.c diff -u php4/ext/bz2/bz2.c:1.61 php4/ext/bz2/bz2.c:1.62

--- php4/ext/bz2/bz2.c:1.61     Sat Oct  5 12:26:57 2002

+++ php4/ext/bz2/bz2.c Sun Dec 1 17:15:38 2002 @@ -16,7 +16,7 @@

    +----------------------------------------------------------------------+

*/ -/* $Id: bz2.c,v 1.61 2002/10/05 16:26:57 wez Exp $ */ +/* $Id: bz2.c,v 1.62 2002/12/01 22:15:38 sterling Exp $ */ #ifdef HAVE_CONFIG_H #include "config.h" @@ -538,6 +538,6 @@ * tab-width: 4 * c-basic-offset: 4 * End: - * vim600: noet sw=4 ts=4 fdm=marker - * vim<600: noet sw=4 ts=4 + * vim600: fdm=marker + * vim: noet sw=4 ts=4 */ Index: php4/ext/sockets/sockets.c diff -u php4/ext/sockets/sockets.c:1.125 php4/ext/sockets/sockets.c:1.126

--- php4/ext/sockets/sockets.c:1.125    Sun Oct 27 22:05:04 2002

+++ php4/ext/sockets/sockets.c Sun Dec 1 17:15:39 2002 @@ -19,7 +19,7 @@

    +----------------------------------------------------------------------+

*/ -/* $Id: sockets.c,v 1.125 2002/10/28 03:05:04 sterling Exp $ */ +/* $Id: sockets.c,v 1.126 2002/12/01 22:15:39 sterling Exp $ */ #ifdef HAVE_CONFIG_H #include "config.h" @@ -797,7 +797,7 @@

        }

        tmpbuf = erealloc(tmpbuf, retval + 1);
-       tmpbuf[ retval ] = '\0' ;
+       tmpbuf[retval] = '\0' ;

        RETURN_STRINGL(tmpbuf, retval, 0);

} @@ -1069,7 +1069,8 @@

                        }

                default:
-                       php_error(E_WARNING, "%s() unsupported socket type '%d', must be AF_UNIX or AF_INET", get_active_function_name(TSRMLS_C), php_sock->type);
+                       php_error(E_WARNING, "%s() unsupported socket type '%d', must be AF_UNIX or AF_INET",
+                     get_active_function_name(TSRMLS_C), php_sock->type);
                        RETURN_FALSE;
        }

@@ -2025,6 +2026,6 @@ * tab-width: 4 * c-basic-offset: 4 * End: - * vim600: noet sw=4 ts=4 fdm=marker - * vim<600: noet sw=4 ts=4 + * vim600: fdm=marker + * vim: noet sw=4 ts=4 */ -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php