Re: cvs: php4(PHP_4_3) /ext/openssl openssl.c

On Thu, 12 Dec 2002, Marcus Börger wrote: > At 14:38 12.12.2002, Edin Kadribasic wrote: > >Don't you thinks its a bit late (after RC3) for this large patch? > > > >Edin > > I don't think whitespace and php_error_docref changes are problematic. Right, but you _did_ break it : - if (timestr->length < 13) { - zend_error(E_WARNING, "%s(): extension author too lazy to parse %s correctly", get_active_function_name(TSRMLS_C), timestr->data); + if (timestr->length < 13) { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "%extension author too lazy to parse %s correctly", timestr->data); (notice the %e). To make sure such things dont happen we should not be doing this this far into the release process. Derick -- ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ -------------------------------------------------------------------------