Re: cvs: php4 /ext/pgsql pgsql.c php_pgsql.h
| From: | Michael Loftis | Date: | Mon, 11 Sep 2000 21:59:42 +0000 |
| Subject: | Re: cvs: php4 /ext/pgsql pgsql.c php_pgsql.h | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-1720@lists.php.net to get a copy of this message | ||
OK, like I said, I hadn't been following it, but seeing that change just
set off a big red flag on my radar :)
Michael
On Tue, 12 Sep 2000 jah@mork.net wrote:
>
>
> On Mon, 11 Sep 2000, Michael Loftis wrote:
>
> > Yes, but what does this break? I'm not sure that just going and doing
> > this is such a good idea. There could be quite a large number of things
> > depending on this little wierdness.
> >
> > And if you're changing that one you should change the pg_clientencoding
> > and setclientencoding to the appropriate as well.
> >
> > I've not been watching the postgres module like I should (especially since
> > I use it in an indirect way) but this just seems to me to be an itch for a
> > problem.
>
> Those functions have been there only 6 hours, so backwards compatibility
> is not an issue here. I'm not going to change the names of any older
> functions.
>
> -- Jouni
>
>