Re: cvs: php4 /ext/standard dns.c
| From: | Derick Rethans | Date: | Fri, 13 Dec 2002 07:41:59 +0000 |
| Subject: | Re: cvs: php4 /ext/standard dns.c | ||
| References: | 1 2 3 4 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-17202@lists.php.net to get a copy of this message | ||
On Thu, 12 Dec 2002, Sara Golemon wrote:
> >>> Bug #17174 Added IPv6 (AAAA record) support to dns_check_record()
> >>> also added support to dns_get_record
> >>
> >>This might break builds on some platforms, as T_AAAA is not always
> >> defined. See the comment in bug #19555.
> >
> > Heh..I should read PHP-CVS folder first.. :)
> > Anyway, I just committed a fix for that prob.
> >
> Instead of:
> #ifdef T_AAAA
> /* blah blah blah */
> #endif
>
> Why not just put:
> #ifndef T_AAAA
> #define T_AAAA 28
> #endif
>
> in dns.h? This should let the function continue working even on platforms
> where T_AAAA isn't defined?
WHere do you get those numbers? Are you sure they are correct? Anywya, I
think the solution Jani introduced is better, now we dont enable code if
it's not available on a platform.
Derick
--
-------------------------------------------------------------------------
Derick Rethans http://derickrethans.nl/
PHP Magazine - PHP Magazine for Professionals http://php-mag.net/
-------------------------------------------------------------------------