Re: cvs: php4 /ext/ncurses ncurses_functions.c

Derick Rethans <derick@php.net> wrote: > On Sun, 22 Dec 2002, Moriyoshi Koizumi wrote: > > > moriyoshi Sun Dec 22 14:51:49 2002 EDT > > > > Modified files: > > /php4/ext/ncurses ncurses_functions.c > > Log: > > Removed "%s" from format strings > > And this is exactly why no patches should be done so far in the release > process, the chance is simply to great for mistakes. You might take me wrong. The error had been there before I committed my docref patch, though I agree with you about my lacking of consideration. Moriyoshi > Derick > > > Index: php4/ext/ncurses/ncurses_functions.c > > diff -u php4/ext/ncurses/ncurses_functions.c:1.30 > > php4/ext/ncurses/ncurses_functions.c:1.31 > > --- php4/ext/ncurses/ncurses_functions.c:1.30 Sun Dec 22 14:44:01 2002 > > +++ php4/ext/ncurses/ncurses_functions.c Sun Dec 22 14:51:49 2002 > > @@ -83,7 +83,7 @@ > > IS_NCURSES_INITIALIZED(); > > RETURN_LONG(color_set(pair,NULL)); > > #else > > - php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s not supported in this build"); > > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "not supported in this build"); > > RETURN_FALSE; > > #endif > > } > > @@ -1047,7 +1047,7 @@ > > IS_NCURSES_INITIALIZED(); > > RETURN_LONG(slk_color(intarg)); > > #else > > - php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s not supported in this build"); > > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "not supported in this build"); > > RETURN_FALSE; > > #endif > > } > > @@ -1122,7 +1122,7 @@ > > IS_NCURSES_INITIALIZED(); > > RETURN_LONG(use_extended_names(intarg)); > > #else > > - php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s not supported in this build"); > > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "not supported in this build"); > > RETURN_FALSE; > > #endif > > } > > @@ -1660,7 +1660,7 @@ > > IS_NCURSES_INITIALIZED(); > > RETURN_LONG(assume_default_colors(i1,i2)); > > #else > > - php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s not supported in this build"); > > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "not supported in this build"); > > RETURN_FALSE; > > #endif > > } > > @@ -2072,7 +2072,7 @@ > > > > RETURN_LONG(wcolor_set(*win, Z_LVAL_PP(color_pair), 0)); > > #else > > - php_error_docref(NULL TSRMLS_CC, E_WARNING,"%s not supported in this build"); > > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "not supported in this build"); > > RETURN_FALSE; > > #endif > > } > > > > > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > -- > > ------------------------------------------------------------------------- > Derick Rethans > http://derickrethans.nl/ > PHP Magazine - PHP Magazine for Professionals > http://php-mag.net/ > ------------------------------------------------------------------------- >