Re: cvs: php4 / acinclude.m4
| From: | Sascha Schumann | Date: | Wed, 20 Sep 2000 01:21:48 +0000 |
| Subject: | Re: cvs: php4 / acinclude.m4 | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-1804@lists.php.net to get a copy of this message | ||
On Tue, 19 Sep 2000, Jani Taskinen wrote:
> sniper Tue Sep 19 16:52:24 2000 EDT
>
> Modified files:
> /php4 acinclude.m4
> Log:
> This fix prevents adding an empty -l to LIBS
>
>
> Index: php4/acinclude.m4
> diff -u php4/acinclude.m4:1.103 php4/acinclude.m4:1.104
> --- php4/acinclude.m4:1.103 Mon Sep 11 08:25:06 2000
> +++ php4/acinclude.m4 Tue Sep 19 16:52:24 2000
> @@ -1,4 +1,4 @@
> -dnl $Id: acinclude.m4,v 1.103 2000/09/11 15:25:06 sas Exp $
> +dnl $Id: acinclude.m4,v 1.104 2000/09/19 23:52:24 sniper Exp $
> dnl
> dnl This file contains local autoconf functions.
>
> @@ -535,7 +535,9 @@
> ])
>
> AC_DEFUN(PHP_X_ADD_LIBRARY,[
> - ifelse($2,,$3="-l$1 [$]$3", $3="[$]$3 -l$1")
> + if test -n "$1"; then
> + ifelse($2,,$3="-l$1 [$]$3", $3="[$]$3 -l$1")
> + fi
> ])
Why don't you fix the caller? The build system is completely
under our control, so I'd prefer to stop passing bad values
instead of adding a check to every invocation of heavily used
macros.
- Sascha