Re: cvs: php4 /ext/pcre/tests bug21732.phpt
| From: | Ilia A. | Date: | Thu, 23 Jan 2003 18:52:23 +0000 |
| Subject: | Re: cvs: php4 /ext/pcre/tests bug21732.phpt | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-18106@lists.php.net to get a copy of this message | ||
On January 23, 2003 01:54 pm, you wrote:
> > > <?php
> > > extension_loaded("pcre") or die("skip pcre extension is not
> > > available"); ?>
> >
> > This check is pointless, since without pcre the testsuit won't run.
>
> Right, I just followed the way in which other tests are written.
> Should we remove those too?
The test for availability of PCRE should be removed IMO simply because without
PCRE test suit will exit before starting any of the tests. The dependency on
PCRE is unlikely to be removed, so this should be a safe thing to do.
Ilia