Re: cvs: php4 /ext/standard proc_open.c /main php_variables.c

From:	Shane Caraveo	Date:	Mon, 24 Mar 2003 18:33:00 +0000
Subject:	Re: cvs: php4 /ext/standard proc_open.c /main php_variables.c
References:	1 2	Groups:	php.cvs
Request:	Send a blank email to php-cvs+get-19731@lists.php.net to get a copy of this message

This changes behaviour and could break BC if people have written work-arounds into their scripts for this (ie removing slashes), which is why I did not MFH. On the other hand, it is the correct behaviour, and in the vast majority of cases it will only be win32 that is effected. The primary reason that this becomes necessary is that we now have a way (in PHP5) to create an environment for the execution of applications via proc_open. Other execution methods will use the environment from PHP (not php script), so shouldn't be effected. Ultimatly, I don't think it makes a difference for 4.3.x. So what do you think, should it MFH? Shane Jani Taskinen wrote:

    MFH?
    --Jani
On Sun, 23 Mar 2003, Shane Caraveo wrote:
shane Sun Mar 23 14:30:31 2003 EDT Modified files: /php4/main php_variables.c /php4/ext/standard proc_open.c Log: The environment should *never* be magic quoted.