Re: cvs: php4 /sapi/apache2handler sapi_apache2.c

On March 25, 2003 08:39 am, Moriyoshi Koizumi wrote: > Hmm..? my patch has not been committed yet, that was only in the list > archives. Although I don't see no problem with your fix, I think you'd > be better off asking the assignee how your patch is before the commit. Hmm... I must've missed your patch :/ > > > "Ilia Alshanetsky" <ilia@prohost.org> wrote: > > > > + if (tlen == count_bytes || !len) { > > > > + break; > > > > + } > > > > > > Is this ok? I suppose tlen would't always be equal to count_bytes. > > > > Yeah this is ok, the idea is to fill the buffer to the end up until the > > point there is either no more data to read (len == 0) or the buffer is > > full (tlen == count_bytes). > > As I was making the same patch, there seems nothing documented > like apr_brigade_flatten() sets len to zero in case the passed brigade > is void. Therefore I think it's potentially dangerous. If brigade is void it would mean that there is/was no more data, hence we break. I did test the with variety of data and md5 checksums checks for data integrity and the problem described in the original bug report has been resolved as far as I can tell. Ilia