Re: cvs: php4 /sapi/apache2handler sapi_apache2.c

this is what I'll be replacing it with. (which was in rev 1.1) char* copy_str; copy_str = apr_pmemdup( ctx->r->pool, str, str_length+1);

        bucket = apr_bucket_pool_create(copy_str, str_length, ctx->r->pool, ctx->c->bucket_alloc);

I'll just to a quick check and then commit this. Moriyoshi Koizumi wrote:

Just curious, but can we append transient buckets here? Moriyoshi "Ian Holsman" <Ian@holsman.net> wrote:

ianh Wed Mar 26 23:35:44 2003 EDT

 Modified files:                 /php4/sapi/apache2handler	sapi_apache2.c  Log:

remove flush from standard unbuffered write. people requiring a flush can turn implicit flush on. Thanks ilia for benchmarking this! Index: php4/sapi/apache2handler/sapi_apache2.c diff -u php4/sapi/apache2handler/sapi_apache2.c:1.9 php4/sapi/apache2handler/sapi_apache2.c:1.10 --- php4/sapi/apache2handler/sapi_apache2.c:1.9 Tue Mar 25 06:50:18 2003 +++ php4/sapi/apache2handler/sapi_apache2.c Wed Mar 26 23:35:44 2003 @@ -18,7 +18,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: sapi_apache2.c,v 1.9 2003/03/25 11:50:18 edink Exp $ */ +/* $Id: sapi_apache2.c,v 1.10 2003/03/27 04:35:44 ianh Exp $ */ #include <fcntl.h> @@ -86,14 +86,6 @@ r->connection->bucket_alloc); APR_BRIGADE_INSERT_TAIL(brigade, bucket); - /* Add a Flush bucket to the end of this brigade, so that - * the transient buckets above are more likely to make it out - * the end of the filter instead of having to be copied into - * someone's setaside. - */ - bucket = apr_bucket_flush_create(r->connection->bucket_alloc); - APR_BRIGADE_INSERT_TAIL(brigade, bucket); - if (ap_pass_brigade(r->output_filters, brigade) != APR_SUCCESS) { php_handle_aborted_connection(); } -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php