Re: cvs: php4 /main fopen_wrappers.c

How about using empty_string? As it can't be freed by STR_FREE(), we can reduce certain risks. Moriyoshit Sterling Hughes <sterling@bumblebury.com> wrote: > On Thu, 2003-03-27 at 01:15, Andi Gutmans wrote: > > OK... :) I hope no one tries to efree() this though. > > > > I hope so too. I'm not sure, between this and return NULL, and then > having callers check for it. > > -Sterling > > > > > At 11:03 PM 3/26/2003 +0000, Sterling Hughes wrote: > > >sterling Wed Mar 26 18:03:48 2003 EDT > > > > > > Modified files: > > > /php4/main fopen_wrappers.c > > > Log: > > > really fix > > > > > > > > >Index: php4/main/fopen_wrappers.c > > >diff -u php4/main/fopen_wrappers.c:1.160 php4/main/fopen_wrappers.c:1.161 > > >--- php4/main/fopen_wrappers.c:1.160 Wed Mar 26 18:01:39 2003 > > >+++ php4/main/fopen_wrappers.c Wed Mar 26 18:03:48 2003 > > >@@ -17,7 +17,7 @@ > > > +----------------------------------------------------------------------+ > > > */ > > > > > >-/* $Id: fopen_wrappers.c,v 1.160 2003/03/26 23:01:39 sterling Exp $ */ > > >+/* $Id: fopen_wrappers.c,v 1.161 2003/03/26 23:03:48 sterling Exp $ */ > > > > > > /* {{{ includes > > > */ > > >@@ -493,7 +493,7 @@ > > > register char *p, *url_start; > > > > > > if (url == NULL) { > > >- return NULL; > > >+ return ""; > > > } > > > > > > p = url; > > > > > > > > > > > >-- > > >PHP CVS Mailing List (http://www.php.net/) > > >To unsubscribe, visit: http://www.php.net/unsub.php > -- > "Reductionists like to take things apart. The rest of us are > just trying to get it together." > - Larry Wall, Programming Perl, 3rd Edition > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >