Re: cvs: php4 /ext/exif exif.c

I don't have time to look through this in a thorough way but I think it could leak now. Maybe it's best if you move this function to getParameters() and convert_to_string() w/o _ex. Andi At 10:07 PM 4/2/2003 +0000, Rasmus Lerdorf wrote:

rasmus          Wed Apr  2 17:07:22 2003 EDT

Modified files:

    /php4/ext/exif      exif.c

Log: MFB: Get rid of bogus dtors Index: php4/ext/exif/exif.c diff -u php4/ext/exif/exif.c:1.141 php4/ext/exif/exif.c:1.142 --- php4/ext/exif/exif.c:1.141 Tue Apr 1 13:50:31 2003

+++ php4/ext/exif/exif.c        Wed Apr  2 17:07:22 2003

@@ -17,7 +17,7 @@

    +----------------------------------------------------------------------+

*/ -/* $Id: exif.c,v 1.141 2003/04/01 18:50:31 rasmus Exp $ */ +/* $Id: exif.c,v 1.142 2003/04/02 22:07:22 rasmus Exp $ */ /* ToDos * @@ -95,7 +95,7 @@ }; /* }}} */ -#define EXIF_VERSION "1.4 $Id: exif.c,v 1.141 2003/04/01 18:50:31 rasmus Exp $" +#define EXIF_VERSION "1.4 $Id: exif.c,v 1.142 2003/04/02 22:07:22 rasmus Exp $" /* {{{ PHP_MINFO_FUNCTION */ @@ -3943,13 +3943,10 @@

                if (!ImageInfo.Thumbnail.width || !ImageInfo.Thumbnail.height) {
                        exif_scan_thumbnail(&ImageInfo TSRMLS_CC);
                }
-               zval_dtor(*p_width);
-               zval_dtor(*p_height);
                ZVAL_LONG(*p_width,  ImageInfo.Thumbnail.width);
                ZVAL_LONG(*p_height, ImageInfo.Thumbnail.height);
        }
        if (arg_c >= 4) {
-               zval_dtor(*p_imagetype);
                ZVAL_LONG(*p_imagetype, ImageInfo.Thumbnail.filetype);
        }

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php