Re: cvs: php4 /ext/bcmath bcmath.c

On Thu, 3 Apr 2003, Derick Rethans wrote: > On Wed, 2 Apr 2003, Rasmus Lerdorf wrote: > > > There was nothing wrong with the indentation. He changed a<b to a < b and > > minor things like that. That's just cvs noise. > > But it's still coding style :) Do a grep through the code. There are literally thousands of instances where there is no space between a variable and an operator. Although, by pointing that out someone is likely to go through and "fix" these and thus making the lives of anybody who rely heavily on cvs diffs a living hell. Also, this is not noise IMO: > > > > > - if(bc_precision<0) bc_precision=0; > > > > + > > > > + if (bc_precision < 0) { > > > > + bc_precision = 0; > > > > + } Well, perhaps. I certainly agree that: if(bc_precision<0) bc_precision=0; is bad because it is easy for someone to get the wrong idea and add a second expression and think it would be covered by the condition. That argument is pretty weak for the single line case. -R