Re: cvs: php4 /main output.c

On Fri, 4 Apr 2003, Andi Gutmans wrote: > I don't think we should back-out these kind of whitespace fixes. I tend to > agree with Jani and I think he's doing a good job whitespacing code. I also Well, indent(1) will probably achieve the same result with the right options.. > think that Rasmus reasoning for not commiting correctly whitespaced code > because we have lots of broken code in PHP, is not very strong. Let's try > at least to have new code shine... As far as I am concerned, no one has made the argument that "correctly whitespacing" actually has any positive effect what-so-ever. My POV is this: Unless white-spacing is severely broken, leave it alone. Don't clutter CVS history. Don't make the job harder for people who handle multi-branch diffs. Do something productive instead. - Sascha