Re: cvs: php4 /ext/xml xml.c

On Thu, 2003-05-01 at 05:22, Thies C. Arntzen wrote: > On Thu, May 01, 2003 at 03:47:55AM -0000, Sterling Hughes wrote: > > sterling Wed Apr 30 23:47:55 2003 EDT > > > > Modified files: > > /php4/ext/xml xml.c > > Log: > > no need to comment out, it doesn't belong there '.' > > may i ask why? If object contains a property that points to the xml parser, than it causes a recursive free of the parser. -Sterling > > > > > > Index: php4/ext/xml/xml.c > > diff -u php4/ext/xml/xml.c:1.117 php4/ext/xml/xml.c:1.118 > > --- php4/ext/xml/xml.c:1.117 Wed Apr 2 20:00:45 2003 > > +++ php4/ext/xml/xml.c Wed Apr 30 23:47:54 2003 > > @@ -17,7 +17,7 @@ > > +----------------------------------------------------------------------+ > > */ > > > > -/* $Id: xml.c,v 1.117 2003/04/03 01:00:45 moriyoshi Exp $ */ > > +/* $Id: xml.c,v 1.118 2003/05/01 03:47:54 sterling Exp $ */ > > > > #define IS_EXT_MODULE > > > > @@ -285,13 +285,6 @@ > > static void xml_parser_dtor(zend_rsrc_list_entry *rsrc TSRMLS_DC) > > { > > xml_parser *parser = (xml_parser *)rsrc->ptr; > > - > > - /* please leave this commented - or ask thies@thieso.net before doing it (again) */ > > -/*#ifdef ZEND_ENGINE_2 > > - if (parser->object) { > > - zval_ptr_dtor(&parser->object); > > - } > > -#endif */ > > > > if (parser->parser) { > > XML_ParserFree(parser->parser); > > > > > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php