Re: cvs: php4 /sapi/apache2filter sapi_apache2.c /sapi/apache2handlersapi_apache2.c

Moriyoshi Koizumi wrote:

Shane Caraveo <shane@caraveo.com> wrote:

It is technicaly wrong to do that. PATH_TRANSLATED should be empty if no PATH_INFO is available. People are using PATH_TRANSLATED in places where they should be using SCRIPT_FILENAME, and thus the reason for the bug report in the first place. Since the apache 2 module is new, it should be done right, and for PHP5, I think all the sapi modules should do this right. For PHP5, cgi, isapi and nsapi (I beleive I saw the fix for nsapi a couple months back) sapi modules are all handling this per spec.

Well, I'll revert the last patch and recategorise that PR as a documentation problem then. Anyway how could we maintain this kind of BC stuff? Sometimes "just technically wrong" isn't enough reason for breaking compatibilities.. Moriyoshi

Well, perhaps it needs a discussion on php-dev, but I'm loath to possibly start a big thread. Shane