Re: cvs: spl / spl_functions.c

On Sun, 25 May 2003, Andi Gutmans wrote: > At 06:02 PM 5/24/2003 +0200, Sascha Schumann wrote: > >On Sat, 24 May 2003, Marcus Boerger wrote: > > > > > helly Sat May 24 11:51:24 2003 EDT > > > > > > Modified files: > > > /spl spl_functions.c > > > Log: > > > fix error resulting from strlen() -> sizeof() change in engine macros > > > > I have not followed the changes, but this might be a good > > idea: > > > > #define fast_str_len(x) \ > > (sizeof(x) == sizeof(void *) ? strlen(x) : sizeof(x)-1) > > > > I.e. if x looks like a pointer, invoke the regular strlen. > > The check will be optimized away by the compiler. > > That would break on fast_str_len("abc"), no? No, it would just return strlen("abc"). - Sascha