Re: cvs: php4 /ext/xml xml.c

On Sun, 2003-06-15 at 13:30, Rob Richards wrote: > From: Sterling Hughes > > > > I think all memory handling should be done with PHP, as you can see > > there are many places in simplexml where I avoid a copy by relying on > > the fact that the libxml2 memory will be allocated by php's mm. > > I saw that. Drove me nuts for a while as libxml kept reporting it as leaks. > Until the memory management is changed, libxml is currently allocating it > and php is free'ing the stuff (hence why it was reporting leaks). > :) > I am fine with having PHP handle all memory management, but if this is the > case, I would say a function somewhere outside the xml extensions that is > called in MINIT of all the libxml enabled extensions. I cant say if this > will complicate debugging this stuff, but would like that noted as a > possible concern (if anyone would care to comment on it). > Right. I think just keeping this in ext/xml or ext/dom is fine. We don't really have any other systems for this atm. > Then, do we even need to worry about re-entrance then? why so? > So, we may define the same memory handling functions a few times. > xmlInitParser is already re-entrant safe. That's fine, its just a function pointer assign. -Sterling > > Rob -- "Nothing is particularly hard if you divide it into small jobs." - Henry Ford