Re: cvs: php-src /ext/session session.c /ext/session/tests bug24592.phpt
| From: | Sascha Schumann | Date: | Tue, 22 Jul 2003 01:20:35 +0000 |
| Subject: | Re: cvs: php-src /ext/session session.c /ext/session/tests bug24592.phpt | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-22698@lists.php.net to get a copy of this message | ||
Ilia, thanks for bringing up this issue, I probably would not
have looked at it otherwise.
> In this case using ZEND_SET_SYMBOL_WITH_LENGTH is overkill. Majority of the
> code inside the macro is not used and the zend_hash_find() is needlesly
> duplicated if the macro is used. Change wise we are talking about 4 lines of
> code versus a 20 line macro most of which is unnecessary operations as far as
> this particular case in concerned.
You are mistaken regarding the use of the macro.
Additionally, your fix completely broke the migration of
references. E.g. this did not work at all anymore:
$bar = 1;
$foo =& $bar;
session_start();
$_SESSION['foo'] = NULL;
I've committed a proper fix which excludes nulls from being
migrated.
- Sascha