Re: cvs: php-src(PHP_4_3) /ext/session session.c

From:	Zeev Suraski	Date:	Tue, 22 Jul 2003 11:18:25 +0000
Subject:	Re: cvs: php-src(PHP_4_3) /ext/session session.c
References:	1 2 3 4	Groups:	php.cvs
Request:	Send a blank email to php-cvs+get-22712@lists.php.net to get a copy of this message

At 13:49 22/07/2003, Sascha Schumann wrote:

On Tue, 22 Jul 2003, Zeev Suraski wrote: At 12:22 22/07/2003, Sascha Schumann wrote:
    If it is not irregular, the engine code should be able to
    deal with it correctly.  Right now, it falls over itself
    quickly and dies ungracefully.
Then ZEND_SET_SYMBOL_WITH_LENGTH should be fixed. I'm not sure who wrote it, but it wasn't Andi nor me. The engine works with it properly, more than that, it completely relies on this behavior.
    Btw, here is the annotated source code.

Ok, I guess I was the one who originally wrote it - it was a very long time ago. Can you give me a concrete example of when you think this macro doesn't behave properly? If it's correct, I'll try to fix it. Note that the last time you had problems with this (and other) macros these were actually bugs in the session module. Zeev