Re: cvs: php-src /ext/simplexml simplexml.c

At 18:10 18/08/2003, Rob Richards wrote:

From: Zeev Suraski PZVAL_UNLOCK() should *never* be used by anything outside the engine. The leak is somewhere else. If that should never be called outside the engine, then the issue seems to be from any extension that needs to override zend_std_read_property. DOM has the same issue, as it currently needs to call pzval_unlock when returning the property value as it uses the libxml structure to store and grab the property values, thus needing to create the zval each time. With no way to clean it up, it just ends up leaking.

I don't have time to thoroughly look into it right now but again, nothing should touch PZVAL_UNLOCK() under any circumstances other than the engine. It's *not* refcount-- equivalent. It has to do with semantics that don't apply to extensions at all. I'm not exactly sure why it's even exported... Zeev