Re: cvs: php-src /ext/dom php_dom.c

At 02:16 19/08/2003, Marcus Börger wrote:

Hello Zeev, Tuesday, August 19, 2003, 1:13:25 AM, you wrote:

ZS> zeev            Mon Aug 18 19:13:25 2003 EDT

ZS> Modified files:

ZS>     /php-src/ext/dom    php_dom.c

ZS> Log: ZS> Get rid of PZVAL_UNLOCK() - fix untested ZS> Index: php-src/ext/dom/php_dom.c ZS> diff -u php-src/ext/dom/php_dom.c:1.23 php-src/ext/dom/php_dom.c:1.24

ZS> --- php-src/ext/dom/php_dom.c:1.23      Sun Jul 27 16:21:36 2003

ZS> +++ php-src/ext/dom/php_dom.c Mon Aug 18 19:13:25 2003 ZS> @@ -18,7 +18,7 @@ ZS> +----------------------------------------------------------------------+ ZS> */ ZS> -/* $Id: php_dom.c,v 1.23 2003/07/27 20:21:36 rrichards Exp $ */ ZS> +/* $Id: php_dom.c,v 1.24 2003/08/18 23:13:25 zeev Exp $ */ ZS> #ifdef HAVE_CONFIG_H ZS> #include "config.h" ZS> @@ -306,8 +306,7 @@

ZS>                 ret = hnd->read_func(obj, &retval TSRMLS_CC);
ZS>                 if (ret == SUCCESS) {
ZS>                         /* ensure we're creating a temporary variable */
ZS> -                       retval->refcount = 1;
ZS> -                       PZVAL_UNLOCK(retval);
ZS> +                       retval->refcount = 0;
ZS>                 } else {
ZS>                         retval = EG(uninitialized_zval_ptr);
ZS>                 }

Ah! yes, thanks!

What? :) Zeev