Re: cvs: php-src /ext/odbc php_odbc.c php_odbc_includes.h
| From: | Jani Taskinen | Date: | Thu, 28 Aug 2003 14:38:56 +0000 |
| Subject: | Re: cvs: php-src /ext/odbc php_odbc.c php_odbc_includes.h | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-23434@lists.php.net to get a copy of this message | ||
On Thu, 28 Aug 2003, Dan Kalowsky wrote:
>On Thursday, August 28, 2003, at 06:08 AM, Jani Taskinen wrote:
>
>> On Wed, 27 Aug 2003, Dan Kalowsky wrote:
>>
>>> + REGISTER_LONG_CONSTANT("SQL_BLOB", SQL_LONGVARBINARY,
>>> CONST_PERSISTENT | CONST_CS);
>>
>> Isn't above supposed to be instead this:
>>
>> REGISTER_LONG_CONSTANT("SQL_BLOB", SQL_BLOB, CONST_PERSISTENT |
>> CONST_CS);
>
>Don't mess with bits you don't understand. To answer your question, no
>it shouldn't.
Fine.
>> I fixed one typo already, maybe you should TEST before you commit
>> things?
>
>Thank you. If you had read the commit you would notice that this is
>for some people to test via a snapshot. If it worked, I planned to
>leave it in, if not, out it comes.
But it's of no use if it can't be compiled. :)
--Jani