Re: cvs: php-src /ext/interbase interbase.c
| From: | (Marcus B�rger) | Date: | Tue, 02 Sep 2003 19:41:24 +0000 |
| Subject: | Re: cvs: php-src /ext/interbase interbase.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-23585@lists.php.net to get a copy of this message | ||
Hello Ard,
Tuesday, September 2, 2003, 9:30:22 PM, you wrote:
> abies Tue Sep 2 15:30:22 2003 EDT
> Modified files:
> /php-src/ext/interbase interbase.c
> Log:
> Make ibase_{param|field}_info() return typenames that actually mean something
> -/* {{{ proto int ibase_num_fields(resource {query|result})
> +/* {{{ proto int ibase_num_fields(resource query|result)
Please don't use | in parameter names, you couldn't do that in php. Make it
query_result or something like that.
And please have a look at CS we prefer case and their statments on different
lines.
--
Best regards,
Marcus mailto:helly@php.net