Re: cvs: php4 /ext/standard info.c info.h /mainmain.c
| From: | Hartmut Holzgraefe | Date: | Tue, 31 Oct 2000 18:08:39 +0000 |
| Subject: | Re: cvs: php4 /ext/standard info.c info.h /mainmain.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-2387@lists.php.net to get a copy of this message | ||
Zeev Suraski wrote:
>
> We have to think about this generalization. It switched 3 strcmp()'s with
> a hash lookup.
and it removes the hard limit of three images, allowing extensions to
add
their own images in MINFO() output without changing global code
[...]
> Generally, I like this abstraction. We need to think of a better way to do it.
>
> Perhaps, we should make two tests - an strncmp() for the 4 bytes or so, to
> see if they're "PHPE", and go on with the hash lookup only if they are.
sounds good,
but can someone explain where theese magic strings did come from in the
first place?
--
Hartmut Holzgraefe hartmut@six.de http://www.six.de
+49-711-99091-77
Besuchen Sie uns auf der Systems in München , Halle C2, Stand 126