Re: cvs: php-src(PHP_4_3) /ext/gd/libgd gdft.c

I guess to answer your question a bit better. Have a look at the top of freetype.h (this time from my Debian box - it's not just Fedora): #ifndef FT_FREETYPE_H #error "`ft2build.h' hasn't been included yet!" #error "Please always use macros to include FreeType header files." #error "Example:" #error " #include <ft2build.h>" #error " #include FT_FREETYPE_H" #endif #ifndef __FREETYPE_H__ #define __FREETYPE_H__ #define FREETYPE_MAJOR 2 #define FREETYPE_MINOR 1 #define FREETYPE_PATCH 7 #include <ft2build.h> #include FT_CONFIG_CONFIG_H #include FT_ERRORS_H #include FT_TYPES_H Now, if we are on a platform where we can't #include on a macro, then this stuff won't compile at all anyway regardless of what we do in PHP. And the error we got before that patch is the one the #error at the top there spits out. -Rasmus On Wed, 26 Nov 2003, Jani Taskinen wrote: > > What exactly is that compile error? And on what platform? > This has been like this for a long time, funny that nobody > hasn't complained before? > > And it works just fine for me on RH9. :) > > --Jani > > > On Tue, 25 Nov 2003, Rasmus Lerdorf wrote: > > >Perhaps not, but Freetype2 won't compile either on those platforms then > >and without this patch we don't build at all. > > > >-Rasmus > > > >On Sat, 22 Nov 2003, Jani Taskinen wrote: > > > >> > >> Are you absolutely sure this will work within any platform? > >> For example, see this bug report: > >> > >> http://bugs.php.net/bug.php?id=25281 > >> > >> --Jani > >> > >> On Sat, 22 Nov 2003, Rasmus Lerdorf wrote: > >> > >> >rasmus Fri Nov 21 19:55:29 2003 EDT > >> > > >> > Modified files: (Branch: PHP_4_3) > >> > /php-src/ext/gd/libgd gdft.c > >> > Log: > >> > Compile fix > >> > > >> > > >> >Index: php-src/ext/gd/libgd/gdft.c > >> >diff -u php-src/ext/gd/libgd/gdft.c:1.11.2.10 > >> >php-src/ext/gd/libgd/gdft.c:1.11.2.11 > >> >--- php-src/ext/gd/libgd/gdft.c:1.11.2.10 Tue Jun 17 09:37:57 2003 > >> >+++ php-src/ext/gd/libgd/gdft.c Fri Nov 21 19:55:29 2003 > >> >@@ -60,7 +60,8 @@ > >> > #else > >> > > >> > #include "gdcache.h" > >> >-#include "freetype/freetype.h" > >> >+#include <ft2build.h> > >> >+#include FT_FREETYPE_H > >> > #include "freetype/ftglyph.h" > >> > > >> > /* number of fonts cached before least recently used is replaced */ > >> > > >> > > >> > >> -- > >> PHP CVS Mailing List (http://www.php.net/) > >> To unsubscribe, visit: http://www.php.net/unsub.php > >> > > > > >