Re: cvs: php-src /ext/standard url.c

On 2003/12/04, at 8:35, Ilia Alshanetsky wrote:

On December 3, 2003 06:21 pm, Moriyoshi Koizumi wrote:

Any reason to remove them? Passing a char-typed value to is*() or to*() is basically wrong.

Compiler does not have a problem with that and we've already established it won't change anything since 'digits' are always lower then then 128-255 range the cast protects.

Although it's not a compiler issue and the casts look ugly, I want to ask those who'll use functions like them to use unsigned char variables in the first place. I've ever spotted numerous mistakes all over the code. That's why I hope they will leave there as my warnings. Moriyoshi p.s. (int)((char)-1) yields -1, rather than 255 of cource.