Re: cvs: php-src /ext/mbstring mbstring.c /ext/mbstring/tests bug26639.phpt

On 2003/12/19, at 0:12, Andi Gutmans wrote:

Shouldn't you be using some SEPARATE*() macro here? It seems as if you're doing something like that.

I didn't try to use that macro because a zval_copy_ctor() call in it would be redundant in this case. It seems REPLACE_ZVAL_VALUE() is a more suitable macro for this purpose. Moriyoshi

+    if ((*hash_entry)->refcount > 1) {
+        ZVAL_DELREF(*hash_entry);
+        MAKE_STD_ZVAL(*hash_entry);
+    } else {
+        zval_dtor(*hash_entry);
+    }
+    ZVAL_STRINGL(*hash_entry, ret->val, ret->len, 0);