Re: cvs: php-src /ext/mysql/tests 001.phpt
| From: | Ilia Alshanetsky | Date: | Fri, 16 Jan 2004 19:26:59 +0000 |
| Subject: | Re: cvs: php-src /ext/mysql/tests 001.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-25680@lists.php.net to get a copy of this message | ||
In all other database extensions ALL tests are skipped if the default
authentication configuration is not applicable, why change things here?
Ilia
On January 16, 2004 02:19 pm, Marcus Boerger wrote:
> Hello Ilia,
>
> Friday, January 16, 2004, 4:16:26 PM, you wrote:
> > iliaa Fri Jan 16 10:16:26 2004 EDT
> >
> > Modified files:
> > /php-src/ext/mysql/tests 001.phpt
> > Log:
> > Added missing skip condition.
> >
> >
> > Index: php-src/ext/mysql/tests/001.phpt
> > diff -u php-src/ext/mysql/tests/001.phpt:1.1
> > php-src/ext/mysql/tests/001.phpt:1.2
> > --- php-src/ext/mysql/tests/001.phpt:1.1 Sun Jan 11 21:31:08 2004
> > +++ php-src/ext/mysql/tests/001.phpt Fri Jan 16 10:16:26 2004
> > @@ -1,5 +1,7 @@
> > --TEST--
> > mysql connect
> > +--SKIPIF--
> > +<?php include 'skipif.inc'; ?>
> > --FILE--
> > <?php
>
> That was a bad idea. I left out the skipif so that the tester sees that the
> database cannot connect via the different connection methods. All other
> tests should of course fail if no connection is possible. Hence skipif.inc
> contains a reduced subset of 001.phpt's contents. So adding it as skipif
> condition to he same test is useless.
>
> --
> Best regards,
> Marcus mailto:helly@php.net