Re: cvs: php-src /ext/standard basic_functions.c /ext/standard/tests/math bug27646.phpt

From: Date: Fri, 26 Mar 2004 19:39:16 +0000
Subject: Re: cvs: php-src /ext/standard basic_functions.c /ext/standard/tests/math bug27646.phpt
References: 1 2 3  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-26790@lists.php.net to get a copy of this message
I mean, it looks like you used NAN twice, when you should have used INF for one of them :-) --Wez. ----- Original Message ----- From: "Marcus Boerger" <helly@php.net> To: "Wez Furlong" <wez@thebrainroom.com> Cc: "Marcus Boerger" <helly@php.net>; <php-cvs@lists.php.net> Sent: Friday, March 26, 2004 7:32 PM Subject: Re: [PHP-CVS] cvs: php-src /ext/standard basic_functions.c /ext/standard/tests/math bug27646.phpt > Hello Wez, > > the general idea is from other source (one that MS copied from ..i forgot > the details). On the mentioned systems a double is 8 bytes (wow). And hence > i need to DWORDS to set it, one gein the high DWORD and one the low. Does > that sound meaningful enough - or do you have a better idea for the name? > Or should i just add the xy_LOW words as 0x00000000 too? > > marcus > > Friday, March 26, 2004, 1:21:27 AM, you wrote: > > > >> +#define PHP_DOUBLE_INFINITY_HIGH 0x7ff00000 > >> +#define PHP_DOUBLE_QUIET_NAN_HIGH 0xfff80000 > >> + > >> +static double php_get_inf() > >> +{ > >> +#if defined(__i386__) || defined(_X86_) || defined(ALPHA) || > > defined(_ALPHA) || defined(__alpha) > >> + double val; > >> + ((php_uint32*)&val)[1] = PHP_DOUBLE_QUIET_NAN_HIGH; > > ^^^^^^^^^^ > > Should this one really be PHP_DOUBLE_INFINITY_HIGH ? > > > --Wez.

« previous php.cvs (#26790) next »