Re: cvs: php-src /scripts phpize.in
| From: | Jan Lehnardt | Date: | Sun, 20 Jun 2004 10:14:59 +0000 |
| Subject: | Re: cvs: php-src /scripts phpize.in | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-27653@lists.php.net to get a copy of this message | ||
Hi,
On 20 Jun 2004, at 1:04, Sascha Schumann wrote:
Since we are not going to support base paths containing
spaces in the build system, I fail to see the point of this
patch. Thus, I consider #28847 to be bogus.
Since I rewrote phpize for PHP 5 I felt responsible for taking
care of the bug not thinking about the build system not
supporting spaces in directory names.
The patch doesn't do any harm though, so I think it can stay in.
Thanks for pointing that out and for updating the bugreport.
Quick thought: Wouldn't it make sense to check if the user
supplies paths we don't support and report that instead of
just failing?
Jan
--
GPG Key: BB96 56B0
Q: Thank Jan? - A: http://geschenke.an.dasmoped.net/