Re: cvs: php-src /ext/iconv iconv.c

On Sat, 14 Aug 2004 12:40:33 +0900 Moriyoshi Koizumi <moriyoshi@at.wakwak.com> wrote: > Antony Dovgal wrote: > > > #include "config.h" > >@@ -2457,7 +2457,7 @@ > > > > while (icnt > 0) { > > if ((ps == NULL ? iconv(self->cd, NULL, NULL, &pd, &ocnt): > >- iconv(self->cd, &ps, &icnt, &pd, &ocnt)) == > >(size_t)-1) {+ iconv(self->cd, (char **)&ps, &icnt, > >&pd, &ocnt)) == (size_t)-1) { > > #if ICONV_SUPPORTS_ERRNO > > switch (errno) { > > case EILSEQ: > > > > I'm afraid it doesn't make much sense. > Please have a look at > > http://marc.theaimsgroup.com/?l=php-dev&m=106279777611117&w=2 > and consider reverting. If you think it's wrong, I'll revert it, of course. But I saw some similar casts in the same file and thought that it's logically right to add one here too. -- Wbr, Antony Dovgal aka tony2001 tony2001@phpclub.net || antony@dovgal.com