RE: [PHP-CVS] cvs: php4(php_4_0_4) / configure.in /main php_version.h

>> >> > At 21:02 3/12/2000, Sascha Schumann wrote: >> > > I don't plan to apply it manually or to review obfuscated >> > > patches. I'd appreciate it though, if Zeev or someone else >> > > would post a patch containing only real changes, to give us a >> > > chance to review it, _before_ committing it to the php_4_0_4 >> > > branch. >> > >> > That's a bit of making a fuss over nothing. Importing the patch as-is >> is fine. >> >> Well, I hate to say it, but that is exactly the kind of >> attitude which caused the pl1 releases. I think we finally >> should learn from our mistakes and not redo them again and >> again. > >Whitespace changes have never caused a pl, a miniversion, or anything, in >the entire history of PHP (well, at least since PHP 3.0 alpha 1, I wasn't >around before that). If we were that bad, then we would have been hopeless >anyway. > >However, the patch itself *is* in fact a patch that may introduce problems, >which is why we need more RCs, and why this branch approach is good. I >chose to put this patch in 4.0.4 because it fixes a corruption bug, which >is a showstopper in my book. The whitespace updates are an added bonus. I think that's why Sascha wanted the whitespace changes separated from the "actual" changes, so we could inspect the "actual" changes more carefully before they become a part of the release branch. It saves us from wading through the commit to see which changes are whitespace related and which changes are actually signifigant if the whitespace changes are removed. -Sterling