Re: cvs: php-src(PHP_5_0) / NEWS /ext/soap php_http.c

On Wed, 1 Dec 2004, Dmitry Stogov wrote: > dmitry Wed Dec 1 11:59:23 2004 EDT > > Modified files: (Branch: PHP_5_0) > /php-src NEWS > /php-src/ext/soap php_http.c > Log: > Fixed bug #30359 (SOAP client requests have no port in "Host" field ). > [snip] > smart_str_appends(&soap_headers, phpurl->host); > + if (phpurl->port != 80) { > + smart_str_appendc(&soap_headers, ':'); > + smart_str_append_unsigned(&soap_headers, phpurl->port); > + } I think this usually also special cases https and port 443. Although, from looking at the spec, there doesn't seem to be any harm in including the port even if it's the default. http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.23 -adam -- adam@trachtenberg.com author of o'reilly's "upgrading to php 5" and "php cookbook" avoid the holiday rush, buy your copies today!