Re: cvs: php-src /ext/standard var_unserializer.c var_unserializer.re

Marcus Boerger wrote:

Hello Stefan, reading the patch twice and checking the code again. Why not simply replace the index type 'iv' with 'uiv' ? "R:" iv ";" -> "R:" uiv ";" "r:" iv ";" -> "r:" uiv ";"

Because that would not fix anything. Both functions do not check for integer overflows when generating the number. So any positive number above 2^31 will be negative when casted to int. Stefan