Re: cvs: php-src /ext/pcre php_pcre.c
| From: | Derick Rethans | Date: | Thu, 09 Dec 2004 15:52:12 +0000 |
| Subject: | Re: cvs: php-src /ext/pcre php_pcre.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-29505@lists.php.net to get a copy of this message | ||
On Thu, 9 Dec 2004, Antony Dovgal wrote:
> tony2001 Thu Dec 9 10:07:57 2004 EDT
>
> Modified files:
> /php-src/ext/pcre php_pcre.c
> Log:
> fix 1-byte leak
>
>
> /* Nothing to do if we got an empty string */
> if (in_str == in_str_end) {
> - RETVAL_STRINGL("", 0, 1);
> + RETVAL_STRINGL("", 0, 0);
> }
This seems wrong, as now the string is not copied and might be freed
somewhere else. Freeing a non allocated string will result in a
segfault, not?
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org