Re: cvs: php-src /ext/standard var.c /ext/standard/tests/array var_export2.phpt

OK I think restoring BC for now is OK. I'm not sure var_dump() really has to support protected/private but the manual says so: "The first one is that the returned representation is valid PHP code, the second that it will also return protected and private properties of an object with PHP 5.". So we might want to fix one or the other at some point :) Andi At 03:33 AM 12/18/2004 +0100, Derick Rethans wrote:

On Fri, 17 Dec 2004, Andi Gutmans wrote: This isn't the right fix. You should just fix the if() statement only return 0 if hash_key->arKey[0] == '\0' && hash_key->nKeyLength > 1. No? No :) This check was for (private and public) properties which should not be don ehere at all (as it's for array elements). Although using binary data as array key is not the wisest thing to do, it DID work always just fine until this unneccesary change. I'm just restoring BC here, as this broken some things for us. regards, Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org