Re: cvs: php-src /sapi/apache2handler php_functions.c
| From: | Joe Orton | Date: | Tue, 11 Jan 2005 15:08:53 +0000 |
| Subject: | Re: cvs: php-src /sapi/apache2handler php_functions.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-29872@lists.php.net to get a copy of this message | ||
On Tue, Jan 11, 2005 at 03:14:16PM +0100, Derick Rethans wrote:
> On Tue, 11 Jan 2005, Joe Orton wrote:
>
> > jorton Tue Jan 11 09:01:32 2005 EDT
> >
> > Modified files:
> > /php-src/sapi/apache2handler php_functions.c
> > Log:
> > Fixed bug #30446 - virtual() includes files out of sequence,
> > work around 2.0 subrequest/internal redirect issue.
>
> > ctx = SG(server_context);
> > +
> > + /* Ensure that the ap_r* layer is flushed, to work around 2.0 bug:
> > + *
> > http://issues.apache.org/bugzilla/show_bug.cgi?id=17629 */
> > + ap_rflush(ctx->r);
> > +
> > return ap_sub_req_lookup_uri(filename, ctx->r, ctx->r->output_filters);
> > }
>
> Why not fix the Apache bug instead? It feels a bit wrong adding
> workarounds to PHP for bugs in other software.
The two actions are not mutually exclusive; the fix will take longer,
the workaround has negligible risk+impact.
joe