Re: cvs: php-src(PHP_4_3) /ext/standard php_var.h var_unserializer.c var_unserializer.re
| From: | Antony Dovgal | Date: | Mon, 17 Jan 2005 11:02:32 +0000 |
| Subject: | Re: cvs: php-src(PHP_4_3) /ext/standard php_var.h var_unserializer.c var_unserializer.re | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-29912@lists.php.net to get a copy of this message | ||
Hi, Stefan!
On Sat, 15 Jan 2005 18:44:30 -0000
"Stefan Esser" <sesser@php.net> wrote:
The patch looks obviously wrong:
> +static inline void var_push_dtor(php_unserialize_data_t *var_hashx,
> zval **rval)+{
..
> + var_push_dtor(var_hash, old_data);
The last line should look like this:
var_push_dtor(var_hash, &old_data);
But even with this fix I got segfault after serialize()/unserialize().
These two tests fail after your fix:
ext/standard/tests/serialize/001.phpt
ext/standard/tests/serialize/bug28325.phpt
--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com