Re: cvs: php4 /ext/gettext gettext.c php_gettext.h

----- Original Message ----- From: "Jani Taskinen" <sniper@iki.fi> To: "Hartmut Holzgraefe" <hartmut@six.de> Cc: "Zak Greant" <zak@nucleus.com>; <php-cvs@lists.php.net> Sent: Friday, December 08, 2000 7:53 PM Subject: Re: [PHP-CVS] cvs: php4 /ext/gettext gettext.c php_gettext.h > On Fri, 8 Dec 2000, Hartmut Holzgraefe wrote: > > >[...] > >> + REGISTER_LONG_CONSTANT("LC_CTYPE", LC_CTYPE, CONST_CS | CONST_PERSISTENT); > >> + REGISTER_LONG_CONSTANT("LC_NUMERIC", LC_NUMERIC, CONST_CS | CONST_PERSISTENT); > >> + REGISTER_LONG_CONSTANT("LC_TIME", LC_TIME, CONST_CS | CONST_PERSISTENT); > >> + REGISTER_LONG_CONSTANT("LC_COLLATE", LC_COLLATE, CONST_CS | CONST_PERSISTENT); > >> + REGISTER_LONG_CONSTANT("LC_MONETARY", LC_MONETARY, CONST_CS | CONST_PERSISTENT); > >> + REGISTER_LONG_CONSTANT("LC_MESSAGES", LC_MESSAGES, CONST_CS | CONST_PERSISTENT); > >> + REGISTER_LONG_CONSTANT("LC_ALL", LC_ALL, CONST_CS | CONST_PERSISTENT); > >[...] > > > > > >i think theese should be defined in ext/standard instead > >and setlocale() should be aware of them to > > I agree. As do I -- I just realized that the message that I sent to Hartmut indicating this, I forgot to cc to the cvs list. > And for now the gettext extension can not be build as > it doesn't include locale.h > > Zak, did you test this before committing? =) :) Absolutely! It works fine on Mandrake 7.1 (and by extension probably any recent linux). What system would it not build for you on? Perhaps I misunderstood something when making my change. The gettext extension includes libintl.h, libintl.h includes locale.h... therefore the constants defined in locale.h should be available to libintl.h and then to gettext.c. --zak