Re: cvs: php-src /ext/pdo_pgsql pgsql_statement.c

From: Date: Wed, 23 Mar 2005 15:36:50 +0000
Subject: Re: cvs: php-src /ext/pdo_pgsql pgsql_statement.c
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-31087@lists.php.net to get a copy of this message
> + Renamed to php_pgsql_unescape_bytea() */ Even though the function is static, please make sure it doesn't have the same name as the one in the pgsql extension. </pedant> > case PDO_PARAM_LOB: > - tmp_ptr = PQunescapeBytea(*ptr, &tmp_len); > + tmp_ptr = php_pgsql_unescape_bytea(*ptr, &tmp_len); > *ptr = estrndup(tmp_ptr, tmp_len); seems like we don't need to duplicate it here anymore; the unescape function allocates its own memory. Can you see if the dup can be eliminated? --Wez.

« previous php.cvs (#31087) next »