Re: cvs: php-src /main main.c

Because the whole PHP documentation talks about ints, even the cast is (int) and the corresponding function intval() :) I thought before naming them :) Andrey Jani Taskinen wrote:

    Why did you name them INT_* when they should be LONG_* ?

    --Jani

On Tue, 19 Apr 2005, Andrey Hristov wrote:

andrey        Tue Apr 19 13:30:08 2005 EDT

Modified files:

   /php-src/main    main.c

Log: add INT_MAX and INT_SIZE constants. #64bit machines are getting wider usage and these are needed http://cvs.php.net/diff.php/php-src/main/main.c?r1=1.623&r2=1.624&ty=u Index: php-src/main/main.c diff -u php-src/main/main.c:1.623 php-src/main/main.c:1.624

--- php-src/main/main.c:1.623    Mon Apr  4 11:06:28 2005
+++ php-src/main/main.c    Tue Apr 19 13:30:07 2005

@@ -18,7 +18,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: main.c,v 1.623 2005/04/04 15:06:28 hirokawa Exp $ */ +/* $Id: main.c,v 1.624 2005/04/19 17:30:07 andrey Exp $ */ /* {{{ includes */ @@ -1437,6 +1437,8 @@

    REGISTER_MAIN_STRINGL_CONSTANT("PHP_CONFIG_FILE_SCAN_DIR", PHP_CONFIG_FILE_SCAN_DIR, sizeof(PHP_CONFIG_FILE_SCAN_DIR)-1, CONST_PERSISTENT | CONST_CS);
    REGISTER_MAIN_STRINGL_CONSTANT("PHP_SHLIB_SUFFIX", PHP_SHLIB_SUFFIX, sizeof(PHP_SHLIB_SUFFIX)-1, CONST_PERSISTENT | CONST_CS);
    REGISTER_MAIN_STRINGL_CONSTANT("PHP_EOL", PHP_EOL, sizeof(PHP_EOL)-1, CONST_PERSISTENT | CONST_CS);
+    REGISTER_MAIN_LONG_CONSTANT("INT_MAX", LONG_MAX, CONST_PERSISTENT | CONST_CS);
+    REGISTER_MAIN_LONG_CONSTANT("INT_SIZE", sizeof(long), CONST_PERSISTENT | CONST_CS);
    php_output_register_constants(TSRMLS_C);
    php_rfc1867_register_constants(TSRMLS_C);