Re: cvs: php-src(PHP_5_0) /ext/mbstring/libmbfl/mbfl mbfilter.c

Current one should be correct (I tested all the cases with my patch). Actually I also wondered, but it seems that former one (I mean "for (i = num; --i >= 0;)" which is commited only to the PHP_5_0 branch) should be a trace of your first patch (in 2005/04/13). The Message From Moriyoshi Koizumi on Sat, 23 Apr 2005 14:27:01 +0900: > > On 2005/04/22, at 14:03, Masaki Fujimoto wrote: > > > @@ -571,7 +573,7 @@ > > /* judge */ > > encoding = NULL; > > > > - for (i = num; --i >= 0;) { > > + for (i = 0; i < num; i++) { > > filter = &flist[i]; > > if (!filter->flag) { > > encoding = filter->encoding; > > > > Looks like this hunk of the change wasn't applied to the other two. > > http://cvs.php.net/diff.php/php-src/ext/mbstring/libmbfl/mbfl/ > mbfilter.c?r1=1.6&r2=1.7&ty=u > http://cvs.php.net/diff.php/php-src/ext/mbstring/libmbfl/mbfl/ > mbfilter.c?r1=1.1.2.6&r2=1.1.2.7&ty=u > > Just wondering which patch is correct... > > Moriyoshi -- Masaki Fujimoto fujimoto@php.net