Re: cvs: php-src /main/streams streams.c
| From: | Antony Dovgal | Date: | Mon, 23 May 2005 15:43:43 +0000 |
| Subject: | Re: cvs: php-src /main/streams streams.c | ||
| References: | 1 2 3 4 5 6 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-31984@lists.php.net to get a copy of this message | ||
On Mon, 23 May 2005 11:31:05 -0400
Wez Furlong <kingwez@gmail.com> wrote:
> 30441 sounds like a bogus bug report because no one can reproduce what
> that guy is seeing.
> 29023 sounds like a valid bug.
> 32649 is a db2 bug report ;)
I mean #32469 (With COM ports (Windows), fread sees nothing until 8K)
Seems to be the very same issue.
> 32810 is a bug, but that's because tmpfile() is implemented as a
> wrapper-less plain file.
As far as I understand wrapper-less streams should not exist at all, right?
> (The|a) correct fix for 32810 is to tag the stream with the
> plain_files_wrapper in _php_stream_fopen_tmpfile().
If you know the correct fix why don't you just fix it then?
> Please revert your commit, because it breaks a *lot* more stuff than it fixes.
> Greedy reads for local files are only really around for BC reasons
> (that nasty fread(, filesize()) thing).
Reverted.
But I would really like to see an example that is broken by this commit.
Could you plz show me one, if it's not too complex for you?
Thanks.
--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com