Re: cvs: php-src /ext/ingres_ii config.m4 php_ii.h

From: Date: Mon, 23 May 2005 20:00:30 +0000
Subject: Re: cvs: php-src /ext/ingres_ii config.m4 php_ii.h
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-31987@lists.php.net to get a copy of this message
On Mon, 23 May 2005, Grant Croker wrote:
#define PHP_II_H @@ -28,6 +33,13 @@ extern zend_module_entry ingres_module_entry; #define phpext_ingres_ptr &ingres_module_entry +/* + Since the buildconf/configure process difers in behaviour between + Linux/UNIX and Windows, the following line allows us to build on + both setups. It's not a perfect solution. +*/ +#define phpext_ingres_ii_ptr &ingres_module_entry
    PLEASE don't commit this kind of crap. Fix it properly!!
    Proper fix: Unify. Change all ingres_ prefixes to ingres_ii_ prefix.
    EVERYWHERE.
    --Jani
#ifdef PHP_WIN32 #define PHP_II_API __declspec(dllexport) http://cvs.php.net/diff.php/php-src/ext/ingres_ii/config.m4?r1=1.11&r2=1.12&ty=u Index: php-src/ext/ingres_ii/config.m4 diff -u php-src/ext/ingres_ii/config.m4:1.11 php-src/ext/ingres_ii/config.m4:1.12 --- php-src/ext/ingres_ii/config.m4:1.11 Mon May 23 08:34:33 2005 +++ php-src/ext/ingres_ii/config.m4 Mon May 23 11:32:59 2005 @@ -1,5 +1,5 @@ dnl -dnl $Id: config.m4,v 1.11 2005/05/23 12:34:33 grantc Exp $ +dnl $Id: config.m4,v 1.12 2005/05/23 15:32:59 grantc Exp $ dnl PHP_ARG_WITH(ingres, for Ingres II support, @@ -8,7 +8,7 @@ if test "$PHP_INGRES" != "no"; then AC_DEFINE(HAVE_II, 1, [Whether you have Ingres II]) - PHP_NEW_EXTENSION(ingres, ii.c, $ext_shared) + PHP_NEW_EXTENSION(ingres_ii, ii.c, $ext_shared) PHP_SUBST(II_SHARED_LIBADD) if test "$PHP_INGRES" = "yes"; then


« previous php.cvs (#31987) next »