Re: cvs: php-src /ext/pdo_pgsql pgsql_driver.c
| From: | Christopher Kings-Lynne | Date: | Fri, 08 Jul 2005 01:29:32 +0000 |
| Subject: | Re: cvs: php-src /ext/pdo_pgsql pgsql_driver.c | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-32787@lists.php.net to get a copy of this message | ||
It is malloc + PQescapeString + free, which in most cases are completely unnecessary. While as Christopher demonstrates sequence name could contain special chars, I'd wager that is a VERY uncommon situation.Uncommon is totally irrelevant. Stable, robust code is what is. What is this - the "Cross your fingers and hope it works programming language"?? Chris