Re: cvs: php4 /ext/standard info.c

I looked at it some more and I guess it looks ok. It's not a 'thorough' solution as it doesn't effect all of the output paths, but then again, it's just a layout issue, so I guess we shoulnd't spend too much time on it... Zeev On Sat, 17 Jun 2000, Zeev Suraski wrote: > > Do we really want to do that? It doesn't really solve the problem (e.g., > the actual values would still be completely off-screen), and in the > general case it looks much less good, IMO. > > I'd either keep it the way it was, or add some code to break large strings > apart at predefined offsets... > > Zeev > > On Sat, 17 Jun 2000, Hartmut Holzgraefe wrote: > > > hholzgra Sat Jun 17 00:08:53 2000 EDT > > > > Modified files: > > /php4/ext/standard info.c > > Log: > > changed default cell alignment to "left" (see bug id #5048) > > > > > > Index: php4/ext/standard/info.c > > diff -u php4/ext/standard/info.c:1.100 php4/ext/standard/info.c:1.101 > > --- php4/ext/standard/info.c:1.100 Fri Jun 16 11:23:57 2000 > > +++ php4/ext/standard/info.c Sat Jun 17 00:08:53 2000 > > @@ -522,7 +522,7 @@ > > row_element = "&nbsp;"; > > } > > php_printf("<TD %s>%s%s%s</td>", > > - (i==0?"BGCOLOR=\"" PHP_ENTRY_NAME_COLOR "\" > > ":"ALIGN=\"center\""), > > + (i==0?"BGCOLOR=\"" PHP_ENTRY_NAME_COLOR "\" > > ":"ALIGN=\"left\""), > > (i==0?"<B>":""), > > row_element, > > (i==0?"</B>":"")); > > > > > > > > > > -- Zeev Suraski <zeev@zend.com> http://www.zend.com/